Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add stats for collections #236

Merged
merged 4 commits into from
Apr 15, 2023
Merged

feat: Add stats for collections #236

merged 4 commits into from
Apr 15, 2023

Conversation

Matehoo
Copy link
Contributor

@Matehoo Matehoo commented Apr 12, 2023 •
edited
Loading

TODO:

  • proper testing

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #10
  • This PR is required for kodadot/nft-gallery#<issue_number>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

vikiival
vikiival reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise nice job

src/mappings/shared/list.ts Outdated Show resolved Hide resolved
src/mappings/utils/helper.ts Outdated Show resolved Hide resolved
@vikiival vikiival mentioned this pull request Apr 12, 2023
Merged
14 tasks
@Matehoo Matehoo requested a review from vikiival April 13, 2023 16:29
@vikiival
Copy link
Member

WDYT @Matehoo ?

I think it looks much cleaner

@Matehoo
Copy link
Contributor Author

Matehoo commented Apr 13, 2023

I also think this way is better, its certainly more performant than before

@vikiival vikiival mentioned this pull request Apr 14, 2023
Closed
@Matehoo
Copy link
Contributor Author

Matehoo commented Apr 14, 2023

@vikiival can we also merge this?

@vikiival
Copy link
Member

I've run the indexer and it hasn't failed?

@Matehoo
Copy link
Contributor Author

Matehoo commented Apr 15, 2023

I've run the indexer and it hasn't failed?

For test I ran the indexer for 30 mins and didnt get any errors related to the added functionality

@vikiival vikiival merged commit 11ad509 into kodadot:main Apr 15, 2023
@yangwao yangwao mentioned this pull request Apr 20, 2023
Closed
@vikiival vikiival added the V2 Implementation of RMRK::2.0.0 label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival

Assignees
No one assigned
Labels
V2 Implementation of RMRK::2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matehoo @vikiival