Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

146 flat image #152

Merged
merged 4 commits into from
Mar 6, 2023
Merged

146 flat image #152

merged 4 commits into from
Mar 6, 2023

Conversation

vikiival
Copy link
Member

  • πŸŽ‰ flat image and media
  • πŸ—ƒοΈ image, media

Thank you for your contribution to the KodaDot Indexer.
πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@vikiival vikiival requested a review from roiLeo February 22, 2023 15:30
@roiLeo
Copy link
Contributor

roiLeo commented Feb 22, 2023

is it done same way on kodadot/rubick? Will it blend?

I still got eslint warning on final.metadata = ensureMetadataUri(event.metadata, collection.type); should we keep this?

@vikiival
Copy link
Member Author

kodadot/rubick

Yes I will do the same there

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight approval

@vikiival vikiival merged commit f38aba1 into main Mar 6, 2023
@vikiival vikiival deleted the 146-flat-image branch March 6, 2023 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flat asset
2 participants