Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partykit handle null connection state #252

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

hassnian
Copy link
Contributor

@yangwao
Copy link
Member

yangwao commented Feb 16, 2024

should I deploy?

@hassnian hassnian marked this pull request as ready for review February 17, 2024 06:07
@hassnian
Copy link
Contributor Author

should I deploy?

sure

@vikiival vikiival merged commit bb30af0 into kodadot:main Feb 17, 2024
3 checks passed
@vikiival
Copy link
Member

Yolo

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

@vikiival has merged but didn't deploy.

@vikiival let us know when it's deployed so we can test

@vikiival
Copy link
Member

vikiival commented Feb 17, 2024

let us know when it's deployed so we can test

I cannot deploy it since this is not a Cloudflare worker.
It is bound to @hassnian or someone else account.

 $ pnpm deploy
 ERR_PNPM_CANNOT_DEPLOY  A deploy is only possible from inside a workspace

Moreover It is missing proper readme :)

@hassnian
Copy link
Contributor Author

let us know when it's deployed so we can test

I cannot deploy it since this is not a Cloudflare worker. It is bound to @hassnian or someone else account.

 $ pnpm deploy
 ERR_PNPM_CANNOT_DEPLOY  A deploy is only possible from inside a workspace

Moreover It is missing proper readme :)

will add ASAP , meanwhile

#251 (comment)

https://docs.partykit.io/guides/deploy-to-cloudflare/

iirc you have to npx partykit login first

then run this command


CLOUDFLARE_ACCOUNT_ID=<your account id> CLOUDFLARE_API_TOKEN=<your api token> npx partykit deploy --domain partykit.domain.com

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

Deploying...
Deployed ./src/index.ts to https://partykit.kodadot.workers.dev

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

docs.partykit.io/guides/deploy-to-cloudflare

iirc you have to npx partykit login first

we will figure out gh action probably as we have there id and token somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants