Use home-made abs to support BigInt in approximately

koddsson · Feb 20, 2024 · 976ad08 · 976ad08
1 parent f78345a
commit 976ad08
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -3013,8 +3013,10 @@ function closeTo(expected, delta, msg) {
   new Assertion(delta, flagMsg, ssfi, true).is.numeric;
   new Assertion(expected, flagMsg, ssfi, true).is.numeric;
 
+  const abs = (x) => x < 0n ? -x : x;
+
   this.assert(
-      Math.abs(obj - expected) <= delta
+      abs(obj - expected) <= delta
     , 'expected #{this} to be close to ' + expected + ' +/- ' + delta
     , 'expected #{this} not to be close to ' + expected + ' +/- ' + delta
   );

diff --git a/test/assert.js b/test/assert.js
@@ -1877,6 +1877,7 @@ describe('assert', function () {
     assert.approximately(1.5, 1.0, 0.5);
     assert.approximately(10, 20, 20);
     assert.approximately(-10, 20, 30);
+    assert.approximately(1n, 2n, 1n);
 
     err(function(){
       assert.approximately(2, 1.0, 0.5, 'blah');