-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get a warning without CodeMirror #32
Comments
easylogic
added a commit
that referenced
this issue
Jun 27, 2019
easylogic
added a commit
that referenced
this issue
Jun 27, 2019
fixed #32, support peerDependency codemirror
Thanks, @easylogic ! |
please test it to v1.9.51 |
Installing 1.9.51:
After installing 1.9.51:
Webpack result
Summary: still in problem |
This package can be ran without CodeMirror, so the policy for setting CodeMirror as a peer dependency is not necessary here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
ColorPicker can be used without CodeMirror, but it still has a dependency on CodeMirror.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Can be used without CodeMirror installation
Additional context
Webpack warning message:
The text was updated successfully, but these errors were encountered: