Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed test to have missing headers which indicated a bug that did not exist #4

Merged

Conversation

adamklifeworks
Copy link
Contributor

No description provided.

@gezpage
Copy link
Contributor

gezpage commented Nov 2, 2022

I'm not sure what value the new test adds since it's 99% copypasta of the test_can_support_requests_lib test, making the reader play spot the difference between the two. Suggest refactoring the tests to avoid duplication, or removing it entirely if it doesn't add value.

@dkraczkowski
Copy link
Contributor

@adamklifeworks Looks good. I would suggest removing this superfluous test.

@adamklifeworks
Copy link
Contributor Author

I've removed the test kept the other updates :)

Copy link
Contributor

@gezpage gezpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamklifeworks 👍

@gezpage gezpage merged commit 47890c9 into kodemore:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants