Change the default logger behavior to adjust to the majority of APMs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majority of APMs like: DataDog - they expect "message" property not "log_message" so I'm proposing to change it. Secondly, if using string prefix then for exmaple DataDog with a default configuration has a problem with parsing values, for exmaple tags are not parsed as "event attributes" but all is displayed as a raw string. If we do not log the string prefix then every property will be tagged correctly.
szymon6927
force-pushed
the
display-log-as-json-only-without-str-prefix
branch
from
3e29d17 to
bdde7dc
Compare
dkraczkowski
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Majority of APMs like: DataDog - they expect "message" property not "log_message" so I'm proposing to change it.
Secondly, if using string prefix then for exmaple DataDog with a default configuration has a problem with parsing values, for exmaple tags are not parsed as "event attributes" but all is displayed as a raw string. If we do not log the string prefix then every property will be tagged correctly.