Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuners and signal status #156

Merged
merged 9 commits into from
Jan 2, 2019
Merged

Tuners and signal status #156

merged 9 commits into from
Jan 2, 2019

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Dec 30, 2018

v3.16.0

  • Added: Tuners and SignalStatus
  • Added: Use Picon Path from OpenWebIf

Introduced the nlohmann/json single header only library to process JSON payloads.

@phunkyfish
Copy link
Member Author

FYI, the json.hpp included has been patched to get around the windows build issue. Link above is for author to work on resolving.

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the strncpy usages should be fixed; the rest is sugar.

src/Enigma2.cpp Outdated Show resolved Hide resolved
src/Enigma2.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
@phunkyfish
Copy link
Member Author

Happy New Year @ksooo !

@phunkyfish
Copy link
Member Author

It wasn't easy to fixup the changes so used a separate commit. Should be ready to go.

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution. Happy New Year @phunkyfish and keep up the good work. Much appreciated.

@phunkyfish phunkyfish merged commit 0a36332 into kodi-pvr:master Jan 2, 2019
@phunkyfish phunkyfish deleted the tuners-and-signal-status branch January 2, 2019 21:30
@phunkyfish
Copy link
Member Author

👍

@Rechi
Copy link
Contributor

Rechi commented Jan 4, 2019

Adding json.hpp from https://github.com/nlohmann/json directly into the git repo is the wrong approach.
It has to be added as dependency.

@phunkyfish
Copy link
Member Author

I’m not entirely sure how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants