Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window_destoryed not firing after latest update #2048

Closed
bahman777 opened this issue Jan 9, 2024 · 2 comments
Closed

window_destoryed not firing after latest update #2048

bahman777 opened this issue Jan 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bahman777
Copy link

I just updated to the latest version. All great except window_destroyed no longer fires. Any help is much appreciated. Running 14.2.1 Mac OS .
@koekeishiya
Copy link
Owner

Uh, my bad.. This check obviously doesn't work properly when a window is destroyed..

if (window_manager_is_window_eligible(window)) {
    event_signal_push(SIGNAL_WINDOW_DESTROYED, window);
}

@koekeishiya koekeishiya added the bug Something isn't working label Jan 9, 2024
koekeishiya added a commit that referenced this issue Jan 14, 2024
@koekeishiya
#2048 fix regression causing window_destroyed signal to not trigger
60380a1
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Jan 14, 2024
@bahman777
Copy link
Author

Thank you. Is there an update? I can't build it - cert issues

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koekeishiya @bahman777