Skip to content

Commit

Permalink
net/macb: fix error return code in macb_probe()
Browse files Browse the repository at this point in the history
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.

Original-idea-by: <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nicolas Ferre authored and davem330 committed Apr 15, 2013
1 parent ab09a6d commit 72ca820
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/cadence/macb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1602,9 +1602,9 @@ static int __init macb_probe(struct platform_device *pdev)
goto err_out_free_irq;
}

if (macb_mii_init(bp) != 0) {
err = macb_mii_init(bp);
if (err)
goto err_out_unregister_netdev;
}

platform_set_drvdata(pdev, dev);

Expand Down

0 comments on commit 72ca820

Please sign in to comment.