Tasks are correctly represented by Deltas using attributes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no more dummy updates and history should work as well
|
Awesome thanks! Will have a look. |
koffeinfrei
reviewed
Nov 29, 2016
| if (checkedAttributor.value(e.target)) | ||
| checkedAttributor.remove(e.target); | ||
| else | ||
| checkedAttributor.add(e.target, true) |
| @@ -4,6 +4,10 @@ const Parchment = Quill.import('parchment'); | |||
| const Module = Quill.import('core/module'); | |||
| const Delta = Quill.import('delta'); | |||
|
|
|||
| //create and register a new class Attributor for checked tasks | |||
| var checkedAttributor = new Parchment.Attributor.Class('checked', 'checked'); | |||
| @@ -15,8 +15,8 @@ | |||
| cursor: default | |||
| pointer-events: all | |||
|
|
|||
| .ql-editor ul.task-list > li.checked | |||
| .ql-editor ul.task-list > li.checked-true | |||
There was a problem hiding this comment.
Is this what parchment produces? Is it possible to retain the class just as checked?
Otherwise this is a breaking change.
There was a problem hiding this comment.
With the way the Attributor is set now, that's what parchment creates. I think it would be possible to have it set the class to only "checked" but then the task's Delta would be represented weirdly (it wouldn't say whether or not the task's checked). At least, that's how I interpreted parchment's kinda confusing docs.
| @@ -17,7 +21,7 @@ class TaskListItem extends ListItem { | |||
| // when inserting a new list item, remove the 'checked' css class | |||
| clone() { | |||
| const clone = super.clone(); | |||
| clone.domNode.classList.remove('checked'); | |||
| checkedAttributor.remove(clone.domNode) | |||
|
Works fine! |
except for the checked-true thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no more dummy updates and history should work as well.