fix: reset remainder after its been used and update date_range_lesser… #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 247 247
Lines 3357 3358 +1
Branches 757 757
=======================================
+ Hits 3335 3336 +1
Misses 21 21
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test
This fixes #222. The issue was that
remainderwas being carried over inside the for loop. Original test didn't catch it because the "below-min-val" was second last (month), so it would only update the year (as it should).If another date part earlier in the array (such as day) was below the minimum value, then remainder would mutate all subsequent parts in the date.