-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs-routes: Fixes backslash issue on Windows #877
base: main
Are you sure you want to change the base?
Conversation
I've found out that downgrading glob from version 10 to 7 also fixes the issue. Currently, package |
glob >= 10.2.7
set glob version to 10.2.7
Improved backslash fix on Windows platforms based on glob option "posix: true"
I've updated my PR because I've probably found a more elegant solution. Instead of calling
I've also updated package.json and package-lock.json to request the latest glob version >= 10.2.7 |
use pulbic npmjs registry
cleanup
peer: true restored
would love to see this merged. hope this project isnt abandoned - long time no update... |
Would also love this merged. I tested this on Windows and it fixes the issues I was having using
Setting that |
Please merge this! |
Can you please elaborate how you done this? I tried to set the following in my package.json in a project referencing
But to no avail. Might be because I am using a somewhat complex monorepo with npm modules and maybe the resolution does not work as I expect. |
Fixes #868 and #871. It fixes the issue at an early stage of the scan-path-for-routes-procedure. Because fs-routes is responsible for resolving routes it should take care that routes are well-formed. This ensures that consuming packages don't need to care about this.