Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the
--size_from_weights
flag to override--dim
andblockdims
and directly loads the previously trained LoRA no matter the shape.This allows finetuning a LoRA that has been resized with
resize_lora.py
(see #243) or with an unknownblockdims
shape.My Current Workflow:
dim=128
resize_lora.py
with--dynamic_method="sv_ratio" --dynamic_param=(between 10 and 20)
to greatly reduce size and untrained noise.There may be a better way to handle the interpretation of block lrs. since there isn't a separate function in
lora.py
to call.