Fix existing offenses for Security/CompoundHash

Co-authored-by: Chris Seaton <chris.seaton@shopify.com>
koic · Apr 9, 2022 · 3426137 · 3426137
1 parent 697dee2
commit 3426137
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/rubocop/cop/offense.rb b/lib/rubocop/cop/offense.rb
@@ -217,7 +217,7 @@ def ==(other)
  alias eql? ==
 
  def hash
- COMPARISON_ATTRIBUTES.reduce(0) { |hash, attribute| hash ^ public_send(attribute).hash }
+ COMPARISON_ATTRIBUTES.map { |attribute| public_send(attribute) }.hash
  end
 
  # @api public

diff --git a/lib/rubocop/cop/variable_force/branch.rb b/lib/rubocop/cop/variable_force/branch.rb
@@ -127,7 +127,7 @@ def ==(other)
  alias_method :eql?, :==
 
  def hash
- control_node.object_id.hash ^ child_node.object_id.hash
+ [control_node.object_id, control_node.object_id].hash
  end
 
  private