Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Implement propose_block RPC #833

Closed
1 task done
sgerbino opened this issue Mar 20, 2024 · 0 comments · Fixed by #834
Closed
1 task done

[FEATURE]: Implement propose_block RPC #833

sgerbino opened this issue Mar 20, 2024 · 0 comments · Fixed by #834
Assignees
Labels
enhancement New feature or request

Comments

@sgerbino
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

New feature

We want to implement a new API call specifically for the block producer to use when proposing new blocks. Unlike submit_block, we want to continue to processing a block despite a failed transaction in order to return a list of failed transactions for the block producer to handle. This new API is considered privileged and therefore should be blacklisted from public use outside the node.

  • Break out submit_block into common code that is used by both propose_block and submit_block
  • Create a new intent enum called block_proposal which will indicate that we want to process the block the "new way"

Note: If the block fails, the response should NOT contain a block receipt (shall contain offending transactions). If the block succeeds, we should attach the block receipt and it shall not contain any offending transactions. The presence of a block receipt should be reliably used to indicate success or failure.

Anything else?

No response

@sgerbino sgerbino added the enhancement New feature or request label Mar 20, 2024
@mvandeberg mvandeberg self-assigned this Mar 21, 2024
mvandeberg added a commit that referenced this issue Mar 25, 2024
mvandeberg added a commit that referenced this issue Mar 26, 2024
mvandeberg added a commit that referenced this issue Mar 27, 2024
sgerbino added a commit that referenced this issue Mar 28, 2024
#833: Implement and test produce_block RPC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants