-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invoke_system_call #813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involves #799
sgerbino
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
- Create a PR for the koinos/koinos-proto changes
- After merge of the koinos/koinos-proto PR, hook this branch up to
master
- Provide a manual test of the
name_service
contract callingget_address
onkoin
- Provide a manual test of a genesis system call such as
get_resource_limits
20db2e8
to
64513b8
Compare
sgerbino
requested changes
Mar 2, 2023
Do we need to handle the case where no ID or name is provided? |
Involves #799
…uments check early
sgerbino
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #799
Brief description
Add
invoke_system_call
Checklist
Demonstration
Invoking system call
get_contract_address
, using the namekoin
This protobuf message is a result object containing the proper address.
Here is invoking it using the name of the system call:
and invoking
get_resource_limits
via id, then name:Invoking with no name or id: