Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a virtual destructor to abstract_chronicler_session #821

Merged
merged 1 commit into from
May 25, 2023
Merged

Add a virtual destructor to abstract_chronicler_session #821

merged 1 commit into from
May 25, 2023

Conversation

youkaicountry
Copy link
Contributor

Resolves #795

Brief description

Adds a virtual destructor to abstract_chronicler_session

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

@sgerbino sgerbino merged commit 8aa020e into master May 25, 2023
@sgerbino sgerbino deleted the 795-ac-destructor branch May 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgerbino sgerbino sgerbino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Abstract chronicler session should have virtual destructor
2 participants
@youkaicountry @sgerbino