fix(cli): use temp file to prevent empty config

koishijs · Aug 12, 2024 · b714847 · b714847
1 parent 2e7e3e5
commit b714847
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/src/command/index.ts b/packages/core/src/command/index.ts
@@ -1,5 +1,5 @@
 import { Awaitable, defineProperty, Time } from 'cosmokit'
-import { Bot, h, Schema, Universal } from '@satorijs/core'
+import { Bot, Fragment, h, Schema, Universal } from '@satorijs/core'
 import { Command } from './command'
 import { Argv } from './parser'
 import validate from './validate'
@@ -25,7 +25,7 @@ declare module '../context' {
     'command-updated'(command: Command): void
     'command-removed'(command: Command): void
     'command-error'(argv: Argv, error: any): void
-    'command/before-execute'(argv: Argv): Awaitable<void | string>
+    'command/before-execute'(argv: Argv): Awaitable<void | Fragment>
     'command/before-attach-channel'(argv: Argv, fields: Set<Channel.Field>): void
     'command/before-attach-user'(argv: Argv, fields: Set<User.Field>): void
   }

diff --git a/packages/loader/src/shared.ts b/packages/loader/src/shared.ts
@@ -254,10 +254,11 @@ export abstract class Loader {
       throw new Error(`cannot overwrite readonly config`)
     }
     if (this.mime === 'application/yaml') {
-      await fs.writeFile(this.filename, yaml.dump(this.config))
+      await fs.writeFile(this.filename + '.tmp', yaml.dump(this.config))
     } else if (this.mime === 'application/json') {
-      await fs.writeFile(this.filename, JSON.stringify(this.config, null, 2))
+      await fs.writeFile(this.filename + '.tmp', JSON.stringify(this.config, null, 2))
     }
+    await fs.rename(this.filename + '.tmp', this.filename)
     if (!silent) this.app.emit('config')
   }