Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 控制台全局捕获了浏览器 Ctrl R 快捷键 #255

Closed
maxoyed opened this issue Nov 24, 2023 · 4 comments
Closed

Bug: 控制台全局捕获了浏览器 Ctrl R 快捷键 #255

maxoyed opened this issue Nov 24, 2023 · 4 comments
Labels
bug Something isn't working domain: console

Comments

@maxoyed
Copy link

maxoyed commented Nov 24, 2023

Describe the bug

除了在explorer editor里,控制台其他页面使用浏览器的 ctrl r 快捷键也不生效

Steps to reproduce

  1. 打开控制台
  2. 在 explorer 以外的页面按下 Ctrl R

Expected behavior

触发浏览器刷新

Screenshots

No response

Versions

System:
OS: Windows 11 10.0.22631
CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-12400F

Binaries:
Node: 18.18.0
Yarn: 1.22.19

Koishi:
Core: 4.15.6
Console: 5.19.1

Additional context

No response

@maxoyed maxoyed added the bug Something isn't working label Nov 24, 2023
@ilharp
Copy link
Member

ilharp commented Nov 24, 2023

这是因为 explorer 插件注册了 Ctrl-R 快捷键,但没有区分作用域导致的吗?禁用 explorer 插件能否解决此问题?

@maxoyed
Copy link
Author

maxoyed commented Nov 24, 2023

这是因为 explorer 插件注册了 Ctrl-R 快捷键,但没有区分作用域导致的吗?禁用 explorer 插件能否解决此问题?

禁用了 explorer 也没用

@shigma shigma transferred this issue from koishijs/koishi Nov 24, 2023
@shigma
Copy link
Member

shigma commented Nov 24, 2023

这是因为 explorer 插件注册了 Ctrl-R 快捷键,但没有区分作用域导致的吗?禁用 explorer 插件能否解决此问题?

explorer 和 market 插件都注册了 Ctrl+R,并且作用域判断存在问题。之后会想办法修复。

@shigma
Copy link
Member

shigma commented Jan 30, 2024

由于控制台自身有 keep-alive 逻辑,导致组件的副作用并没有清除,实际上两个快捷键同时生效。

因此应当考虑将组件是否 alive 纳入考察标准。

@shigma shigma closed this as completed in 498e486 Jan 31, 2024
CyanChanges pushed a commit to CyanForks/webui that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working domain: console
Projects
None yet
Development

No branches or pull requests

3 participants