Emit plugin error on failure

[eduardolundgren]

When not able to parse it should emit an error to be able to catch from the stream level.

[koistya]

Thanks!

[tonyganch]

processString method accepts file name as third parameter:
https://github.com/csscomb/core#combprocessstringstring-syntax-filename
You could just run var output = comb.processString(file.contents.toString('utf8'), syntax, file.path) without all those buffers and try/catch blocks that slow things down.

[koistya]

@tonyganch yeah, I'm already passing file.path to the processString(..) method. But since it throws an exception if parsing fails, I guess wrapping it in a try catch makes sense. No?

https://github.com/koistya/gulp-csscomb/blob/master/index.js#L57-L62

[tonyganch]

@koistya, I think that for some reason you do a lot of work that has already been done and tested.
Maybe processing files with gulp is really tricky, I don't know.
But for example, processFile(path) checks whether file syntax is supported and uses it.
getCustomConfig() checks whether there is a custom config somewhere and loads it.

A lot of cool stuff is added to CSScomb when people need it.
If you believe that processString should log parser errors instead of throwing them, you can just open an issue/PR and propose/discuss some changes.

[eduardolundgren]

Even if processFile(path) checks if the file extension is supported you can still pass a invalid content to it. If it breaks on a stream chain it causes several issues, e.g. stopping a watch listener. Throwing a gulp plugin error is the recommendation and standard for those situations.