Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] main from nushell:main #527

Merged
merged 4 commits into from
Nov 27, 2024
Merged

[pull] main from nushell:main #527

merged 4 commits into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. Always populate config record during startup (#14435) 

    # Description

As a bit of a follow-on to #13802 and #14249, this (pretty much a
"one-line" change) really does *always* populate the `$env.config`
record with the `nu-protocol::config` defaults during startup. This
means that an `$env.config` record is value (with defaults) even during:

* `nu -n` to suppress loading of config files
* `nu -c <commandstring>`
* `nu <script>`

# User-Facing Changes

There should be no case in which there isn't a valid `$env.config`.

* Before:

  ```nushell
  nu -c "$env.config"
  # -> Error
  ```

* After:

  ```nushell
  nu -c "$env.config"
  # -> Default $env.config record
  ```

Startup time impact is negligible (17.072µs from `perf!` on my system) -
Seems well worth it.

# Tests + Formatting

Added tests for several `-n -c` cases.

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`

# After Submitting

Config chapter update still in progress.
    @NotTheDr01ds
    NotTheDr01ds authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1c18e37 View commit details
    Browse the repository at this point in the history

  2. Fix unstable test case: One time my windows report drive letter as lo… 

    …wercase (#14451)

As I'm working on PWD-per-drive feature. Once the plugin test of env
failed. I checked the log, found sometime Windows can give drive letter
as lowercase, so the test case should be rewrite to check first letter
caseinsensitive equal, and following part normal equal.

```
assert_eq! failed at tests/plugins/env.rs:43:5
left: r"e:\Study\Nushell"
right: r"E:\Study\Nushell"
```

---------

Co-authored-by: Zhenping Zhao <pegasus.cadence@gmail.com>
    @PegasusPlusUS
    PegasusPlusUS and Zhenping Zhao authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    bd37473 View commit details
    Browse the repository at this point in the history

  3. Propagate existing errors in insert and merge (#14453) 

    # Description
Propagate existing errors in the pipeline, rather than a type error.

# User-Facing Changes
Nothing that previously worked should be affected, this should just
change the errors.

# Tests + Formatting

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`
    @Bahex
    Bahex authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0aafc29 View commit details
    Browse the repository at this point in the history

  4. Bump reedline to current main (#14455) 

    # Description

@fdncred mentioned that we should be dogfooding the latest Reedline
changes in Nushell. Hoping I got the steps correct.

# User-Facing Changes

New keybindings for:

* Insert Newline: <kbd>Alt</kbd>+<kbd>Enter</kbd> and
<kbd>Shift</kbd>+<kbd>Enter</kbd>
* Enter:  <kbd>Ctrl</kbd>+<kbd>J</kbd>

# Tests + Formatting

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`

# After Submitting
    @NotTheDr01ds
    NotTheDr01ds authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5e7263c View commit details
    Browse the repository at this point in the history