Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pervasive build failures on geminga (Trilinos' Version of Kokkos-Kernels) #347

Closed
csiefer2 opened this issue Nov 21, 2018 · 4 comments
Closed

Comments

@csiefer2
Copy link
Contributor

A bunch of the print_specialization functions are only defined if KOKKOSKERNELS_ENABLE_TPL_BLAS is enabled, yet are used if
KOKKOSKERNELS_ENABLE_TPL_CUBLAS is enabled.

This leads to pervasive build failures. If both of these really need to be enabled to make the code work, this mismatch should be detected at configure time.

See:
https://testing.sandia.gov/cdash/viewBuildError.php?buildid=4197910

@csiefer2 csiefer2 changed the title Pervasive build failures on geminga Pervasive build failures on geminga (Trilinos' Version of Kokkos-Kernels) Nov 21, 2018
@csiefer2
Copy link
Contributor Author

As per @ndellingwood Kokkos-Kernels will not build if TPL_ENABLE_BLAS is disabled when CUBLAS is enabled.

@ndellingwood
Copy link
Contributor

See these lines of code:

CMakeLists.txt

@ndellingwood
Copy link
Contributor

Suggested fix:

After this line, enable BLAS if not enabled. That is

IF(${Kokkos_ENABLE_Cuda})
IF (NOT KOKKOSKERNELS_ENABLE_TPL_BLAS)
  SET(KOKKOSKERNELS_ENABLE_TPL_BLAS ON)
  LIST(APPEND TPL_LIST "BLAS")
ENDIF()
...

ndellingwood added a commit that referenced this issue Nov 21, 2018

Verified

This commit was signed with the committer’s verified signature.
lidel Marcin Rataj
Address issue #347 reported by @csiefer2
@crtrott
Copy link
Member

crtrott commented Dec 4, 2018

Solved in #348.

ndellingwood added a commit to ndellingwood/Trilinos that referenced this issue Dec 5, 2018

Verified

This commit was signed with the committer’s verified signature.
lidel Marcin Rataj
When CUBLAS=ON set BLAS=ON if not explicitly enabled.
See kokkos/kokkos-kernels#347
tjfulle pushed a commit to tjfulle/Trilinos that referenced this issue Dec 6, 2018
When CUBLAS=ON set BLAS=ON if not explicitly enabled.
See kokkos/kokkos-kernels#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants