League size off-by-one in some places #478
Labels
Cleanup
Code maintenance that isn't a bugfix or new feature
Comments
brian-kelley
added a commit
to brian-kelley/kokkos-kernels
that referenced
this issue
Mar 6, 2020
(an example of kokkos#478, which is incorrect integer division with rounding up)
brian-kelley
added a commit
to brian-kelley/kokkos-kernels
that referenced
this issue
Mar 9, 2020
(an example of kokkos#478, which is incorrect integer division with rounding up)
brian-kelley
added
the
Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In many places, KokkosKernels calculates the league size as
num_rows / rows_per_team + 1. In most cases this is exactly correct, but ifrows_per_teamdividesnum_rowsevenly then the number of teams is 1 greater than needed. I'm sure the runtime overhead for one extra team that returns immediately is very small, but I propose that we fix this by changing these to(num_rows + rows_per_team - 1) / rows_per_team). That is equivalent toceil((double) num_rows / rows_per_team).The text was updated successfully, but these errors were encountered: