Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KokkosBlas::dot: Poor accuracy with float on Mac Clang causes Trilinos test failure #574

Closed
mhoemmen opened this issue Jan 22, 2020 · 7 comments
Closed

KokkosBlas::dot: Poor accuracy with float on Mac Clang causes Trilinos test failure #574

mhoemmen opened this issue Jan 22, 2020 · 7 comments
Assignees
@mhoemmen
Labels
enhancement InDevelop

Comments

@mhoemmen
Copy link
Contributor

See trilinos/Trilinos#6633.
@ndellingwood
Copy link
Contributor

@mhoemmen would you submit a PR with your fix from the Trilinos PR?

mhoemmen pushed a commit to mhoemmen/kokkos-kernels that referenced this issue Jan 22, 2020
Fix kokkos#574 (improve KokkosBlas::dot accuracy for float)
0d8f83c 
For vectors of `float`, the two-argument overload of KokkosBlas::dot
(that takes two vectors (rank-1 Views) as input, and returns the dot
product result as a scalar value on host) gets inaccurate results on
Mac Clang.  This commit fixes that overload of KokkosBlas::dot so that
if the dot product result type is float resp. complex<float>, the
function uses double resp. complex<double> as the type for
intermediate sums.

This change, when applied to Trilinos in Pull Request
trilinos/Trilinos#6634, fixes Trilinos issue
trilinos/Trilinos#6633.
@ndellingwood
Copy link
Contributor

If so I can test and will cherry-pick into the release candidate.

@mhoemmen
Copy link
Contributor Author

@ndellingwood #575 :-)

@mhoemmen
Copy link
Contributor Author

@ndellingwood I just fixed the base branch in that PR, btw.

This was referenced Jan 22, 2020
Merged
Merged
@mhoemmen
Copy link
Contributor Author

@ndellingwood FYI I had forgotten to test a change for complex. I will fix it.

mhoemmen pushed a commit to mhoemmen/kokkos-kernels that referenced this issue Jan 23, 2020
Fix kokkos#574 (improve KokkosBlas::dot accuracy for float)
66c2a6c 
For vectors of `float`, the two-argument overload of KokkosBlas::dot
(that takes two vectors (rank-1 Views) as input, and returns the dot
product result as a scalar value on host) gets inaccurate results on
Mac Clang.  This commit fixes that overload of KokkosBlas::dot so that
if the dot product result type is float resp. complex<float>, the
function uses double resp. complex<double> as the type for
intermediate sums.

This change, when applied to Trilinos in Pull Request
trilinos/Trilinos#6634, fixes Trilinos issue
trilinos/Trilinos#6633.
@mhoemmen
Copy link
Contributor Author

@ndellingwood I fixed it :-)

@ndellingwood
Copy link
Contributor

PR #575 merged, will be included in 3.0 release.

ndellingwood added a commit that referenced this issue Jan 27, 2020
@ndellingwood
Merge pull request #575 from mhoemmen/Fix-574
2872ee5 
Fix #574 (improve KokkosBlas::dot accuracy for float & complex<float>)
@ndellingwood ndellingwood mentioned this issue Jan 28, 2020
Merged
@kokkos-devops-admin kokkos-devops-admin mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhoemmen mhoemmen

Labels
enhancement InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @ndellingwood