Eigendecomposition error with intel/17.0.1 and MKL

[ndellingwood]

Compilation errors are occurring in KokkosBatched_Eigendecomposition_Serial_Internal.hpp with intel/17.0.1 and MKL enabled. This was detected in the nightly tests on kokkos-dev-2 after including intel/17.0.1 to the list of compilers to test.

Sample error:

/ascldap/users/ndellin/kokkos-kernels/src/batched/KokkosBatched_Eigendecomposition_Serial_Internal.hpp(86): error: identifier "LAPACK_ROW_MAJOR" is undefined
            const auto matrix_layout = ( as1 == 1 ? LAPACK_ROW_MAJOR : LAPACK_COL_MAJOR );
                                                    ^
          detected during:
            instantiation of "int KokkosBatched::SerialEigendecomposition::invoke(const AViewType &, const EViewType &, const EViewType &, const UViewType &, const UViewType &, const WViewType &) [with AViewType=Kokkos::View<double **, Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::HostSpace::memory_space>, Kokkos::MemoryManaged>, EViewType=Kokkos::View<double *, Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space,
                      Kokkos::HostSpace::memory_space>, Kokkos::MemoryManaged>, UViewType=Kokkos::View<double **, Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::HostSpace::memory_space>, Kokkos::MemoryManaged>, WViewType=Kokkos::View<double *, Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::HostSpace::memory_space>, Kokkos::MemoryManaged>]" at line 46 of
                      "/ascldap/users/ndellin/kokkos-kernels/unit_test/batched/Test_Batched_SerialEigendecomposition.hpp"
            instantiation of "void Test::Functor_TestBatchedSerialEigendecomposition<DeviceType, ViewRank3Type, ViewRank2Type>::operator()(int) const [with DeviceType=Kokkos::Serial, ViewRank3Type=Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, ViewRank2Type=Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>]" at line 553 of
                      "/ascldap/users/ndellin/kokkos-kernels/testing/cmTestAllSandia-tpls/TestAll_2020-04-27_08.25.32/intel/17.0.1/Serial-release/kokkos-install/include/Kokkos_Serial.hpp"
            instantiation of "std::enable_if<std::is_same<TagType, void>::value, void>::type Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::Serial>::exec<TagType>() const [with FunctorType=Test::Functor_TestBatchedSerialEigendecomposition<Kokkos::Serial, Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>>, Traits=<Kokkos::Serial::execution_space>, TagType=void]" at line 569 of
                      "/ascldap/users/ndellin/kokkos-kernels/testing/cmTestAllSandia-tpls/TestAll_2020-04-27_08.25.32/intel/17.0.1/Serial-release/kokkos-install/include/Kokkos_Serial.hpp"
            instantiation of "void Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::Serial>::execute() const [with FunctorType=Test::Functor_TestBatchedSerialEigendecomposition<Kokkos::Serial, Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>>, Traits=<Kokkos::Serial::execution_space>]" at line 182 of
                      "/ascldap/users/ndellin/kokkos-kernels/testing/cmTestAllSandia-tpls/TestAll_2020-04-27_08.25.32/intel/17.0.1/Serial-release/kokkos-install/include/Kokkos_Parallel.hpp"
            instantiation of "void Kokkos::parallel_for(const ExecPolicy &, const FunctorType &, const std::string &, std::enable_if<Kokkos::is_execution_policy<ExecPolicy>::value, void>::type *) [with ExecPolicy=Kokkos::RangePolicy<Kokkos::Serial::execution_space>, FunctorType=Test::Functor_TestBatchedSerialEigendecomposition<Kokkos::Serial, Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>>]" at line 232 of
                      "/ascldap/users/ndellin/kokkos-kernels/testing/cmTestAllSandia-tpls/TestAll_2020-04-27_08.25.32/intel/17.0.1/Serial-release/kokkos-install/include/Kokkos_Parallel.hpp"
            instantiation of "void Kokkos::parallel_for(const std::string &, const ExecPolicy &, const FunctorType &) [with ExecPolicy=Kokkos::RangePolicy<Kokkos::Serial::execution_space>, FunctorType=Test::Functor_TestBatchedSerialEigendecomposition<Kokkos::Serial, Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>>]" at line 60 of
                      "/ascldap/users/ndellin/kokkos-kernels/unit_test/batched/Test_Batched_SerialEigendecomposition.hpp"
            instantiation of "void Test::Functor_TestBatchedSerialEigendecomposition<DeviceType, ViewRank3Type, ViewRank2Type>::run() [with DeviceType=Kokkos::Serial, ViewRank3Type=Kokkos::View<double ***, Kokkos::LayoutLeft, Kokkos::Serial>, ViewRank2Type=Kokkos::View<double **, Kokkos::LayoutLeft, Kokkos::Serial>]" at line 90 of "/ascldap/users/ndellin/kokkos-kernels/unit_test/batched/Test_Batched_SerialEigendecomposition.hpp"
            instantiation of "void Test::impl_test_batched_eigendecomposition<DeviceType,ValueType,LayoutType>(int, int) [with DeviceType=Kokkos::Serial, ValueType=double, LayoutType=Kokkos::LayoutLeft]" at line 100 of "/ascldap/users/ndellin/kokkos-kernels/unit_test/batched/Test_Batched_SerialEigendecomposition.hpp"
            instantiation of "int test_batched_eigendecomposition<DeviceType,ValueType>() [with DeviceType=Kokkos::Serial, ValueType=double]" at line 9 of "/ascldap/users/ndellin/kokkos-kernels/unit_test/batched/Test_Batched_SerialEigendecomposition_Real.hpp"

Reproducer instructions:

  #   Load modules:
        module load sems-env sems-cmake/3.12.2 kokkos-env kokkos-hwloc/1.10.1/base sems-intel/17.0.1

  #   Use generate_makefile line below to call cmake which generates makefile for this build:
        $KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-devices=Serial --arch=SNB,Volta70 --compiler=/projects/sems/install/rhel7-x86_64/sems/compiler/intel/17.0.1/base/bin/icpc --cxxflags="-O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized " --cxxstandard="11" --ldflags=""  --kokkos-path=$KOKKOS_PATH --kokkoskernels-path=/$KOKKOSKERNELS_PATH --with-scalars='' --with-ordinals= --with-offsets= --with-layouts= --with-tpls=mkl    --with-options= --with-cuda-options= --no-examples --with-options=enable_large_mem_tests

@kyungjoo-kim can you take a look at this? I'm guessing that intel/17 has the older mkl interface which may be causing the issue?