-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #1171 from lucbv/Fix_using_namespace #1173
Conversation
I had to resolve conflicts with the cherry-pick, hoping I didn't make a mistake but please review carefully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndellingwood this looks good and as long as you remove the three using namespace KokkosBatched
we are fine since missing another change will lead to build failure which is easy to detect : )
Yuck, thanks for the catch! I don't understand why that change didn't carry over with the cherry-pick, will need to better understand that |
Oop, I misinterpreted as a change request my mistake. I looked over the files changed diff and confirm the three culprit using namespace lines have been removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lucbv and @ndellingwood !
using namespace should be scoped to prevent name clashes, see issue kokkos#1170 (cherry picked from commit e9496bb)
ee05ade
to
1b52c78
Compare
@lucbv @e10harvey I force pushed an update to fix an error during testing (some funky duplication during cherry-pick, maybe I made a mistake resolving conflicts). The change resolved the error picked up in a Cuda_Serial build but have a failing |
using namespace should be scoped to prevent name clashes, see issue #1170
(cherry picked from commit e9496bb)