Fix nightly builds following promotion of the math functions in Kokkos #1339

dalg24 · 2022-02-22T13:19:40Z

…depending on KOKKOS_VERSION

kokkos-devops-admin · 2022-02-22T13:25:28Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

lucbv · 2022-02-22T15:13:52Z

@dalg24 it looks like you missed this one

dalg24 · 2022-02-22T15:18:25Z

@dalg24 it looks like you missed this one

Fixed. Thank you.

kokkos-devops-admin · 2022-02-22T21:45:44Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

kokkos-devops-admin · 2022-02-22T21:50:21Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Build Num: 91
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 862
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 508
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 852
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 840
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 245
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)

Pull Request Author: dalg24

kokkos-devops-admin · 2022-02-23T00:28:48Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Build Num: 91
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 862
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 508
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 852
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 840
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 245
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_math_functions
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5abbd09`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`16fef26`
PR_LABELS	Cleanup
PULLREQUESTNUM	1339
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2022-02-23T00:29:05Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

kokkos-devops-admin · 2022-02-23T00:29:12Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

lucbv

Thanks for the clean-up!

dalg24 added 3 commits February 22, 2022 08:16

Fixup prefer std::fabs on the host-side and drop pointless cast

db27faf

Fixup conditionally use sqrt from Kokkos:: or Kokkos::Experimental:: …

aa6b100

…depending on KOKKOS_VERSION

Adjust Kokkos version for math functions in Kokkos:: namespace

2989f2d

lucbv mentioned this pull request Feb 22, 2022

Add unit test for BsrMatrix and BlockCrsMatrix spmv #1338

Merged

lucbv requested review from e10harvey, brian-kelley and lucbv and removed request for e10harvey February 22, 2022 15:13

lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Feb 22, 2022

Cleanup prefer std::sqrt on the host-side

5abbd09

ndellingwood added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 22, 2022

kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 22, 2022

lucbv approved these changes Feb 23, 2022

View reviewed changes

lucbv merged commit d2dfd94 into kokkos:develop Feb 23, 2022

dalg24 deleted the kokkos_math_functions branch February 23, 2022 02:35

lucbv mentioned this pull request Feb 24, 2022

Reduce lots of macro duplication in sparse unit tests #1340

Merged

Fix nightly builds following promotion of the math functions in Kokkos #1339

Fix nightly builds following promotion of the math functions in Kokkos #1339

Conversation

dalg24 commented Feb 22, 2022

kokkos-devops-admin commented Feb 22, 2022

lucbv commented Feb 22, 2022

dalg24 commented Feb 22, 2022

kokkos-devops-admin commented Feb 22, 2022

kokkos-devops-admin commented Feb 22, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Feb 23, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

kokkos-devops-admin commented Feb 23, 2022

kokkos-devops-admin commented Feb 23, 2022

lucbv left a comment

Choose a reason for hiding this comment