Drop "fenl" example #1655
Closed
Drop "fenl" example #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srajama1 do you know who is using/needing this? I have also wanted to remove this for a while now... |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Superseded by PR #1657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out since #737 that is 2y 1/2 ago but presumably does not compile for much longer than that.
kokkos-kernels/example/fenl/VectorImport.hpp
Lines 114 to 117 in ddf1b3d
is what caught my eye.
Kokkos::Impl::StaticAssertwas removed almost 4y ago (see kokkos/kokkos#2130)Just being pragmatic. Fix or remove. I suggest remove.