Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLAS: fix assignable check in gemv and gemm #1914

Merged
merged 1 commit into from
Jul 27, 2023
Merged

BLAS: fix assignable check in gemv and gemm #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions blas/src/KokkosBlas2_gemv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ void gemv(const execution_space& space, const char trans[],
Kokkos::SpaceAccessibility<execution_space,
typename YViewType::memory_space>::accessible,
"KokkosBlas::gemv: YViewType must be accessible from execution_space");
static_assert(
Kokkos::SpaceAccessibility<typename YViewType::memory_space,
typename AViewType::memory_space>::assignable,
"KokkosBlas::gemv: AViewType must be assignable to YViewType");
static_assert(
Kokkos::SpaceAccessibility<typename YViewType::memory_space,
typename XViewType::memory_space>::assignable,
"KokkosBlas::gemv: XViewType must be assignable to YViewType");

// Check compatibility of dimensions at run time.
if (trans[0] == 'N' || trans[0] == 'n') {
Expand Down
8 changes: 0 additions & 8 deletions blas/src/KokkosBlas3_gemm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,6 @@ void gemm(const execution_space& space, const char transA[],
Kokkos::SpaceAccessibility<execution_space,
typename CViewType::memory_space>::accessible,
"KokkosBlas::gemm: CViewType must be accessible from execution_space");
static_assert(
Kokkos::SpaceAccessibility<typename CViewType::memory_space,
typename AViewType::memory_space>::assignable,
"KokkosBlas::gemm: CViewType must be assignable by AViewType");
static_assert(
Kokkos::SpaceAccessibility<typename CViewType::memory_space,
typename BViewType::memory_space>::assignable,
"KokkosBlas::gemm: CViewType must be assignable by BViewType");

// Check validity of transpose argument
bool valid_transA = (transA[0] == 'N') || (transA[0] == 'n') ||
Expand Down