Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fences in agreement with Kokkos deprecations #425

Merged
merged 1 commit into from
May 15, 2019

Conversation

ndellingwood
Copy link
Contributor

See kokkos/kokkos#2140
The fence as a static member function of execution spaces was
deprecated, made non-static.

See kokkos/kokkos#2140
The fence as a static member function of execution spaces was
deprecated, made non-static.
@ndellingwood
Copy link
Contributor Author

Spot-check running on kokkos-dev-2. This is required for the 2.9 release.

@ndellingwood
Copy link
Contributor Author

Host spot-check results:


Running on machine: sems
Going to test compilers:  gcc/5.3.0 gcc/7.2.0 intel/17.0.1 clang/3.9.0 cuda/9.2
Testing compiler gcc/5.3.0
Testing compiler gcc/7.2.0
Testing compiler intel/17.0.1
  Starting job gcc-7.2.0-Serial-release
  Starting job gcc-5.3.0-OpenMP-release
  PASSED gcc-5.3.0-OpenMP-release
Testing compiler clang/3.9.0
  Starting job intel-17.0.1-OpenMP-release
  PASSED gcc-7.2.0-Serial-release
Testing compiler cuda/9.2
  Starting job clang-3.9.0-Pthread_Serial-release
  PASSED intel-17.0.1-OpenMP-release
  PASSED clang-3.9.0-Pthread_Serial-release

Cuda failed because I forgot to set the correct arch, will update this comment after rerunning the Cuda builds.

@ndellingwood
Copy link
Contributor Author

A power outage is preventing me from copy/pasting the cuda results. Merging this PR, will paste results once I have access again.

@ndellingwood ndellingwood merged commit 1105273 into develop May 15, 2019
@ndellingwood
Copy link
Contributor Author

Cuda spot-check results from kokkos-dev-2:

Running on machine: sems
Going to test compilers:  cuda/9.2
Testing compiler cuda/9.2
  Starting job cuda-9.2-Cuda_OpenMP-release
  PASSED cuda-9.2-Cuda_OpenMP-release
  Starting job cuda-9.2-Cuda_Pthread-release
  PASSED cuda-9.2-Cuda_Pthread-release
  Starting job cuda-9.2-Cuda_Serial-release
  PASSED cuda-9.2-Cuda_Serial-release
#######################################################
PASSED TESTS
#######################################################
cuda-9.2-Cuda_OpenMP-release build_time=436 run_time=283
cuda-9.2-Cuda_Pthread-release build_time=409 run_time=362
cuda-9.2-Cuda_Serial-release build_time=415 run_time=371
#######################################################
FAILED TESTS
#######################################################

@ndellingwood ndellingwood deleted the update-fences branch May 16, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants