Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing and KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND #485

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Update testing and KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND #485

merged 1 commit into from
Oct 25, 2019

Conversation

ndellingwood
Copy link
Contributor

Resurfaced issue #349, update to macro for CXX14 workaround issues.
Added gcc/7.4 to testing on white testbed.
Added support for kokkos-dev-2 system for testing.
Extra fixes caught while spot-check testing on kokkos-dev-2

  • Shadow warning of type in KokkosSparse_spmv_struct_impl.hpp
  • Missing test for Threads backend in KokkosGraph_color_d2.cpp

@ndellingwood
Update testing and KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND
57a0ecc 
Resurfaced issue #349, update to macro for CXX14 workaround issues.
Added gcc/7.4 to testing on white testbed.
Added support for kokkos-dev-2 system for testing.
Extra fixes caught while spot-check testing on kokkos-dev-2
* Shadow warning of type in KokkosSparse_spmv_struct_impl.hpp
* Missing test for Threads backend in KokkosGraph_color_d2.cpp
@ndellingwood ndellingwood requested a review from srajama1 October 25, 2019 20:22
@ndellingwood
Copy link
Contributor Author

@srajama1 Spot-check passed with c++14 support on the gcc's 7.2, 7.3, 7.4, and spot-check on kokkos-dev-2. Due to issues that popped up that I fixed along the way I don't have a clean screen output of passing tests to post.

@ndellingwood
Copy link
Contributor Author

Follow-up items:

  1. Re-enable -Werror for the clang builds on kokkos-dev-2 when we resume testing off of Kokkos' develop branch
  2. Add nightly testing on kokkos-dev-2 when PR is merged

@ndellingwood
Copy link
Contributor Author

@aprokop thanks for reporting, I'm assuming this PR is not as important to you as a fix in Trilinos so I'll put a patch in for the KOKKOS_IMPL_BATCHED_GEMM_GCC_CXX14_WORKAROUND update you required.

@ndellingwood ndellingwood mentioned this pull request Oct 25, 2019
Closed
srajama1
srajama1 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@srajama1 srajama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndellingwood Thanks ! Looks good, let me know if we can merge.

@srajama1
Copy link
Contributor

Can we file an issue for this, so we don't forget.

Follow-up items:

1. Re-enable `-Werror` for the clang builds on kokkos-dev-2 when we resume testing off of Kokkos' develop branch

2. Add nightly testing on kokkos-dev-2 when PR is merged

@ndellingwood
Copy link
Contributor Author

@srajama1 will do! I'll merge this in, can you approve the trilinos/Trilinos#6164 patch as well? I have that set to auto-merge, it is only the 1-line change Andrey requested, the other cleanup stuff in this PR can come in during the next promotion when we clobber Trilinos' kokkos-kernels.

@ndellingwood ndellingwood merged commit 5d42fb8 into develop Oct 25, 2019
@ndellingwood ndellingwood deleted the update-testing branch October 25, 2019 22:47
@ndellingwood
Copy link
Contributor Author

@srajama1 issue created with follow-up items, trial run of first automated build on kokkos-dev-2 successful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajama1 srajama1 srajama1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndellingwood @srajama1