Fix #665 (Graph's device type inside CrsMatrix) #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for StaticCrsGraph typedef inside CrsMatrix. This is important for when the device type uses a different memory space than the default for the exec space (which Tpetra will want to do with CudaSpace soon).
ndellingwood
approved these changes
Mar 25, 2020
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "execution_space" with "device_t" for the StaticCrsGraph typedef inside CrsMatrix. This is important for when the device type uses a different memory space than the default for the exec space (which Tpetra will want to do with CudaSpace soon).
kokkos-dev2:
#######################################################
PASSED TESTS
#######################################################
clang-8.0-Pthread_Serial-release build_time=68 run_time=373
cuda-10.1-Cuda_OpenMP-release build_time=246 run_time=325
cuda-9.2-Cuda_Serial-release build_time=309 run_time=435
gcc-7.3.0-OpenMP-release build_time=54 run_time=374
gcc-7.3.0-Pthread-release build_time=58 run_time=203
gcc-8.3.0-Serial-release build_time=54 run_time=193
gcc-9.1-OpenMP-release build_time=78 run_time=195
gcc-9.1-Serial-release build_time=74 run_time=193
intel-18.0.5-OpenMP-release build_time=164 run_time=209
#######################################################
FAILED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release (test failed) (#645)
#######################################################
RIDE:
#######################################################
PASSED TESTS
#######################################################
cuda-10.1.105-Cuda_OpenMP-release build_time=474 run_time=413
cuda-10.1.105-Cuda_Serial-release build_time=475 run_time=517
cuda-9.2.88-Cuda_OpenMP-release build_time=465 run_time=547
cuda-9.2.88-Cuda_Serial-release build_time=448 run_time=662
gcc-6.4.0-OpenMP_Serial-release build_time=156 run_time=387
gcc-7.2.0-OpenMP-release build_time=96 run_time=129
gcc-7.2.0-OpenMP_Serial-release build_time=162 run_time=361
gcc-7.2.0-Serial-release build_time=100 run_time=226
ibm-16.1.0-Serial-release build_time=496 run_time=397