Add cuda test and fix weird segmentation error coming from enum conversion. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it test scalar algorithms
on white, nvcc wrapper (gcc 5.4) does not translate between - enum : int - static constexpr int - static const int this is quite confusing as all the code is valid and work well when gcc is used by itself.
crtrott
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to not being able to convert among
enum : int,constexpr intandstatic const intwhennvcc_wrapperis used. When g++ is directly used, the error does not appear. However, withnvcc_wrapper, mixing the above types is dangerous.static const intconsistently.