Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supernode-based SpTrsv updates #739

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

iyamazaki
Copy link
Contributor

This PR

  • adds "partitioned-inverse" option based on SpMV through Cholmod interface

  • merge some changes for improving performance

@iyamazaki iyamazaki requested a review from ndellingwood June 15, 2020 15:27
@iyamazaki
Copy link
Contributor Author

Spot-check on White:

../scripts/cm_test_all_sandia --spot-check --arch=Power8,Pascal60 --num=1

#######################################################
PASSED TESTS
#######################################################
cuda-10.1.105-Cuda_OpenMP-release build_time=590 run_time=168
cuda-10.1.105-Cuda_Serial-release build_time=657 run_time=185
cuda-9.2.88-Cuda_OpenMP-release build_time=613 run_time=183
cuda-9.2.88-Cuda_Serial-release build_time=591 run_time=202
gcc-6.4.0-OpenMP_Serial-release build_time=235 run_time=145
gcc-7.2.0-OpenMP-release build_time=146 run_time=65
gcc-7.2.0-OpenMP_Serial-release build_time=206 run_time=142
gcc-7.2.0-Serial-release build_time=136 run_time=71
ibm-16.1.1-Serial-release build_time=973 run_time=74

../scripts/cm_test_all_sandia --spot-check-tpls --arch=Power8,Pascal60 --cxxflags-extra='-DKOKKOSKERNELS_ENABLE_SUPERNODAL_SPTRSV=ON' --num=1

#######################################################
PASSED TESTS
#######################################################
cuda-10.1.105-Cuda_Serial-release build_time=731 run_time=184
cuda-9.2.88-Cuda_OpenMP-release build_time=719 run_time=188
gcc-7.2.0-OpenMP-release build_time=165 run_time=63
gcc-7.2.0-Serial-release build_time=153 run_time=72
gcc-7.4.0-OpenMP-release build_time=178 run_time=60

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passes spot-checks, thanks @iyamazaki !

@ndellingwood ndellingwood merged commit bc2f491 into kokkos:develop Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants