Fix >1024 team size error in sort_crs_* #872
Merged
+33
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test that replicated the issue.
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found by Mike Gilbert when sorting a matrix with at least one very long row (>2048 entries).
Also add a test that replicated the issue.
#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=730 run_time=142
clang-8.0-Pthread_Serial-release build_time=242 run_time=132
clang-9.0.0-Pthread-release build_time=156 run_time=61
clang-9.0.0-Serial-release build_time=164 run_time=50
cuda-10.1-Cuda_OpenMP-release build_time=911 run_time=144
cuda-11.0-Cuda_OpenMP-release build_time=924 run_time=142
cuda-9.2-Cuda_Serial-release build_time=878 run_time=226
gcc-7.3.0-OpenMP-release build_time=166 run_time=47
gcc-7.3.0-Pthread-release build_time=144 run_time=62
gcc-8.3.0-Serial-release build_time=164 run_time=52
gcc-9.1-OpenMP-release build_time=214 run_time=47
gcc-9.1-Serial-release build_time=193 run_time=51
intel-18.0.5-OpenMP-release build_time=689 run_time=49
intel-19.0.5-Pthread-release build_time=333 run_time=64
#######################################################
FAILED TESTS
#######################################################
intel-17.0.1-Serial-release (build failed)
#######################################################
(The only reason intel 17 failed is it couldn't load the license)