Fix HBW support #3343
Merged
Fix HBW support #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
Sep 4, 2020
dalg24
reviewed
Sep 4, 2020
| (reinterpret_cast<uintptr_t>(ptr) & alignment_mask)) { | ||
| std::ostringstream msg; | ||
| msg << "Kokkos::Experimental::HBWSpace::allocate[ "; | ||
| switch (m_alloc_mech) { | ||
| case STD_MALLOC: msg << "STD_MALLOC"; break; | ||
| case POSIX_MEMALIGN: msg << "POSIX_MEMALIGN"; break; | ||
| case POSIX_MMAP: msg << "POSIX_MMAP"; break; | ||
| case INTEL_MM_ALLOC: msg << "INTEL_MM_ALLOC"; break; |
There was a problem hiding this comment.
Consider raising an error in default clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2941 (comment). There was typo in
cmake/KokkosCore_config.h.inand a missig define incmake/kokkos_tpls.cmakeso this could never be used withCMake. The corresponding Makefile logic iskokkos/Makefile.kokkos
Lines 622 to 635 in 03ded4e
As a result,
clang-tidywas complaining again and we needed some modifications related to the profiling interface.