Added VERSION and SOVERSION to KOKKOS_INTERNAL_ADD_LIBRARY #3706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The question here is whether we want the SOVERSION to be
${Kokkos_VERSION_MAJOR}
or${Kokkos_VERSION_MAJOR}.${Kokkos_VERSION_MINOR}
. The answer probably boils down to whether we want to "guarantee" new minor versions don't introduce new symbols which must be directly linked to. Given all the templates, I went ahead and assumed that would be difficult to enforce so I set SOVERSION to use the major and minor version (but we can change this).Previously, we had:
This produces:
Closes #3687