Deprecate parallel_* overloads taking the label as later argument #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Jun 23, 2022
dalg24
reviewed
Jun 24, 2022
crtrott
previously requested changes
Jun 29, 2022
|
|
||
| #ifdef KOKKOS_ENABLE_DISABLE_DEPRECATED_CODE_3 | ||
| template <class ExecutionPolicy, class FunctorType, class ReturnType> | ||
| inline void parallel_scan( |
There was a problem hiding this comment.
Annotate with the deprecation attribute?
There was a problem hiding this comment.
Good catch! See db9c848.
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Jun 30, 2022
Compatibility update for future kokkos@3.7.00 release kokkos/kokkos#5141
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 5, 2022
Compatibility update for future kokkos@3.7.00 release kokkos/kokkos#5141
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 12, 2022
Compatibility update for future kokkos@3.7.00 release kokkos/kokkos#5141
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not even documented, see https://github.com/kokkos/kokkos/wiki/Kokkos::parallel_for, https://github.com/kokkos/kokkos/wiki/Kokkos::parallel_reduce, and https://github.com/kokkos/kokkos/wiki/Kokkos::parallel_scan.