Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYCL: Remove workaround for submit_barrier not being enqueued properly #5504

Merged
merged 1 commit into from
Apr 11, 2023
Merged

SYCL: Remove workaround for submit_barrier not being enqueued properly #5504

merged 1 commit into from
Apr 11, 2023

Conversation

masterleinad
Copy link
Contributor

Needs intel/llvm#6359 and intel/llvm#6888 (or manually setting SYCL_PI_LEVEL_ZERO_USE_MULTIPLE_COMMANDLIST_BARRIERS=1 as environment variable).
Also updates the AOT architectures.
I would consider merging it already if it passes CI (which I expect).

@masterleinad masterleinad force-pushed the sycl_remove_enqueue_barrier_memcpy_workaround branch from ee2fbc4 to f8f203a Compare March 16, 2023 18:23
@masterleinad masterleinad marked this pull request as ready for review March 16, 2023 18:23
dalg24
dalg24 requested changes Mar 16, 2023
View reviewed changes
core/src/SYCL/Kokkos_SYCL_Space.cpp Outdated Show resolved Hide resolved
@masterleinad masterleinad force-pushed the sycl_remove_enqueue_barrier_memcpy_workaround branch from f8f203a to 229fc9a Compare March 16, 2023 20:44
@masterleinad masterleinad force-pushed the sycl_remove_enqueue_barrier_memcpy_workaround branch from 229fc9a to be14872 Compare March 16, 2023 20:45
@masterleinad masterleinad requested a review from dalg24 March 16, 2023 20:45
@dalg24
Copy link
Member

dalg24 commented Mar 16, 2023

Will ignore failure in the CUDA RDC build

5: [ RUN      ] cuda.workgraph_fib
5: /var/jenkins/workspace/Kokkos/core/unit_test/TestWorkGraph.hpp:127: Failure
5: Expected equality of these values:
5:   h_values(0)
5:     Which is: 322
5:   full_fibonacci(m_input)
5:     Which is: 377
5: [  FAILED  ] cuda.workgraph_fib (1366 ms)

@dalg24 dalg24 merged commit 0702062 into kokkos:develop Apr 11, 2023
@fnrizzi fnrizzi mentioned this pull request Apr 13, 2023
Closed
masterleinad added a commit to masterleinad/kokkos that referenced this pull request Apr 13, 2023
@masterleinad
Partially reverse kokkos#5504
71bd405
masterleinad added a commit to masterleinad/kokkos that referenced this pull request Apr 13, 2023
@masterleinad
Partially reverse kokkos#5504
079268c
@dalg24
Copy link
Member

dalg24 commented Apr 14, 2023

Uggg I merged with SYCL CI build failing...

@masterleinad
Copy link
Contributor Author

Uggg I merged with SYCL CI build failing...

Yes, I also missed checking again...

dalg24 added a commit that referenced this pull request Apr 14, 2023
@dalg24
Merge pull request #6056 from masterleinad/partially_reverse_5504
9004274 
Partially reverse #5504: SYCL: Remove workaround for submit_barrier not being enqueued properly
masterleinad added a commit to masterleinad/kokkos that referenced this pull request Apr 24, 2023
@masterleinad
Partially reverse kokkos#5504
e5d1ffa
@masterleinad masterleinad mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masterleinad @dalg24 @Rombur