add more warp sync for cuda reductions #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a priority for the 4.2.01 patch release as well? |
ndellingwood
approved these changes
Jan 25, 2024
masterleinad
approved these changes
Jan 25, 2024
|
CI issues with the Cuda builds, each have |
|
Unrelated machine issue. Ignoring. |
ndellingwood
pushed a commit
to ndellingwood/kokkos
that referenced
this pull request
Jan 25, 2024
…id_race_conditions add more warp sync for cuda reductions (cherry picked from commit d8ace97)
|
Cherry-pick to release-candidate-4.2.01 PR #6751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More
__syncwarp()calls to avoid potential race conditions in cuda reductions. See #6630.