Update strided_index_range to strided_slice #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its confusing extents<> with the function exetents()
mhoemmen
approved these changes
Jan 24, 2023
| using offset_type = OffsetType; | ||
| using extent_type = ExtentType; | ||
| using stride_type = StrideType; | ||
|
|
||
| OffsetType offset; | ||
| ExtentType extent; | ||
| StrideType stride; | ||
|
|
||
| static_assert(is_integral<OffsetType>::value || __mdspan_is_integral_constant<OffsetType>::value); |
There was a problem hiding this comment.
Thanks for adding the Mandates! : - )
Optionally, given that the P2630 implementation only needs to support C++17, would you consider using is_integral_v<T> instead of is_integral<T>::value?
There was a problem hiding this comment.
I think I got confused with the error message for is_integra_constant_v which doesn't exist :-)
crtrott
force-pushed
the
update-strided-slice
branch
from
80354a2
to
5702ddc
Compare
nmm0
approved these changes
Jan 25, 2023
mhoemmen
added a commit
to mhoemmen/mdspan
that referenced
this pull request
Jul 26, 2023
Don't unconditionally include <execution>. Fixes kokkos#231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.