BUG: fix caching for user-defined functor vars #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes kokkos#173 * add a regression test for kokkosgh-173 and fix the issue by invalidating the workunit cache when user-defined variables are used in a kernel * this just builds on my previous skepticism that our cache is actually "safe"/useful as you can see from the previous comments in the code in this area * this fix may be more aggressive than needed, but since this fixes a bug it seems justified to me even if there is a broader performance implication, since the tests clearly are not in place to handle these cases
NaderAlAwar
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BUG: variable assignment not propagated #173
add a regression test for BUG: variable assignment not propagated #173 and fix the issue by invalidating the workunit cache when user-defined variables are used in a kernel
this just builds on my previous skepticism that our cache is actually "safe"/useful as you can see
from the previous comments in the code in this area
this fix may be more aggressive than needed, but since this fixes a bug it seems justified to me even if there is a broader performance implication, since the tests clearly are not in place to handle these cases