Add optimization that automatically adds the restrict keyword to kernels #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trict optimization
gliga
reviewed
Mar 12, 2024
| def add_parent_refs(classdef: ast.ClassDef) -> ast.ClassDef: | ||
| """ | ||
| Add references to each node's parent node in classdef (Copied from | ||
| static.py, can't be imported due to circular import) |
There was a problem hiding this comment.
could it be moved to a util file and then imported in both places?
There was a problem hiding this comment.
Yes, would require some more refactoring. I'll get to this in a later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature (enabled by setting the
PK_RESTRICTenvironment variable) to automatically addrestrictto views, which tells the compiler that the restricted views/arrays do not alias, enabling it optimize the code better. The alias analysis is done automatically by PyKokkos.Ideally we would use the
Kokkos::Restrictmemory trait, however most compilers ignorerestrictwith pointers that are member variables (as it is with Kokkos Views). This PR solves this issue by generating aKOKKOS_FUNCTIONthat accepts the raw view pointers as arguments which we can then userestrictwith.