Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented automatic album art #48

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

sdasda7777
Copy link
Contributor

Fixes #47

@sdasda7777 sdasda7777 marked this pull request as draft September 24, 2023 11:31
RockSniffer/RPC/AlbumArtResolver.cs Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
@kokolihapihvi
Copy link
Owner

Is this usage is permitted by the Apple Music terms of service?

@sdasda7777
Copy link
Contributor Author

Is this usage is permitted by the Apple Music terms of service?

I don't know if it is explicitly permitted, but I don't think it's forbidden (went through this: https://www.apple.com/legal/internet-services/itunes/us/terms.html , I think that is likely the most relevant). Obviously I'm not a lawyer, but given there is no money involved, I don't think it would be worth Apple's time of day anyway.

@sdasda7777 sdasda7777 marked this pull request as ready for review September 27, 2023 15:51
@kokolihapihvi kokolihapihvi self-assigned this Sep 27, 2023
Copy link
Owner

@kokolihapihvi kokolihapihvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just some small nitpicks left.

RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/AlbumArtResolver.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
RockSniffer/RPC/DiscordRPCHandler.cs Outdated Show resolved Hide resolved
@kokolihapihvi kokolihapihvi merged commit 07824fe into kokolihapihvi:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Discord RPC Album Art
2 participants