Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Show translate button only if translator is available #76

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

caipira113
Copy link
Contributor

What

The button is displayed only when translation is available on the server.

Why

image_2023-06-19_00-41-29-01
There was an issue where the button appeared even though translatorAvailable was false.

Additional info (optional)

image_2023-06-19_00-59-31-01
image_2023-06-19_01-00-05-01

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15 ⚠️

Comparison is base (a2f2f02) 78.47% compared to head (11b9a52) 78.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    78.47%   78.33%   -0.15%     
===========================================
  Files          182      180       -2     
  Lines        23150    22993     -157     
  Branches       509      509              
===========================================
- Hits         18168    18011     -157     
  Misses        4982     4982              
Impacted Files Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)
...kages/frontend/src/components/MkSubNoteContent.vue 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noridev
Copy link
Collaborator

noridev commented Jun 18, 2023

😘🙏

@noridev noridev merged commit be15081 into kokonect-link:develop Jun 18, 2023
@caipira113 caipira113 deleted the translatorAvailable branch June 18, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants