fix(restifyGH-1604): plugins.serveStatic no dep dirname

Fixes restify#1604 There should be no dependency on the dirname for specific path.
kolbma · May 26, 2022 · c85da14 · c85da14
1 parent d7f32ea
commit c85da14
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/lib/plugins/static.js b/lib/plugins/static.js
@@ -186,13 +186,9 @@ function serveStatic(options) {
         } else if (opts.appendRequestPath) {
             file = path.join(docRoot, decodeURIComponent(req.path()));
         } else {
-            var dirBasename = path.basename(docRoot);
             var reqpathBasename = decodeURIComponent(path.basename(req.path()));
 
-            if (
-                path.extname(reqpathBasename) === '' &&
-                dirBasename === reqpathBasename
-            ) {
+            if (!path.extname(reqpathBasename)) {
                 file = docRoot;
             } else {
                 file = path.join(docRoot, reqpathBasename);

diff --git a/test/plugins/static.test.js b/test/plugins/static.test.js
@@ -476,6 +476,31 @@ describe('static resource plugin', function() {
         );
     });
 
+    // directory differs from path without appendPath
+    it('GH-1604 handling should not depend on directory name', function(done) {
+        var tmpDir = '.tmp';
+
+        function cb() {
+            CLIENT.get('/public/', function(err, req, res, obj) {
+                assert.ifError(err);
+                assert.equal(res.statusCode, 200);
+                done();
+            });
+        }
+
+        serveStaticTest(
+            cb,
+            true,
+            tmpDir,
+            tmpDir + '/test',
+            '/test',
+            null,
+            null,
+            false,
+            null
+        );
+    });
+
     // To ensure this will always get properly restored (even in case of a test
     // failure) we do it here.
     var originalCreateReadStream = fs.createReadStream;