Fix Crossfade #87
Open
Fix Crossfade #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLynnSmith
force-pushed
the
feature/fix_crossfade_transition
branch
2 times, most recently
from
0a19c72
to
bd643c1
Compare
JonathanLynnSmith
force-pushed
the
feature/fix_crossfade_transition
branch
from
bd643c1
to
3230f0d
Compare
kolbyjack
reviewed
Apr 1, 2023
Comment on lines
+146
to
+151
| if(self.config.crossfade){ | ||
| images = document.getElementsByClassName("crossfade-image") | ||
| if(images.length > 1 ){ | ||
| images[0].style.opacity = 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
Should call this on self.wrapper, as there may be multiple MMM-Wallpaper modules on the page, and one shouldn't affect the others. Also, should keep the formatting consistent with the rest of the file:
Suggested change
| if(self.config.crossfade){ | |
| images = document.getElementsByClassName("crossfade-image") | |
| if(images.length > 1 ){ | |
| images[0].style.opacity = 0 | |
| } | |
| } | |
| if (self.config.crossfade) { | |
| images = self.wrapper.getElementsByClassName("crossfade-image"); | |
| if (images.length > 1) { | |
| images[0].style.opacity = 0; | |
| } | |
| } |
| @@ -19,6 +19,7 @@ | |||
| } | |||
|
|
|||
| .MMM-Wallpaper .crossfade-image { | |||
| position: absolute; | |||
There was a problem hiding this comment.
I tested this code and while it does fix the issues with the crossfade, this doesn't seem to work when the fillRegion param is set to false. I want the slideshow to play in a specific region of the magic mirror display; not the whole background, and setting the position to absolute overrides the width/height values I've set up in the config and it fills the whole region with a cropped image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some issues with the crossfade feature. I made these small adjustments to resolve.