build: ping python and upgrade poetry #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And directly download instantclient.
And show cpan module build logs on failure.
And remove mental health term from the descripion
Make sure the container can be run without a TTY, e.g. deploying changes
when testing in a CI pipeline.
The following pipes and redirects are now possible:
$ ./docker-sqitch.sh
$ ./docker-sqitch.sh < file
$ ./docker-sqitch.sh < file | less
$ ./docker-sqitch.sh | less
$ echo | ./docker-sqitch.sh | less
$ echo | ./docker-sqitch.sh
$ echo | ./docker-sqitch.sh > file
$ ./docker-sqitch.sh > file
And upgrade the ODBC driver. Thanks to @peter-wimsey for the fix! Closes sqitchers#49.
Fix file creation for Windows
And keep the build on Bullseye for now. Upgrade Open JDK for the Exasol image since v11 is no longer available.
And add the misssing SNOWSQL_ROLE environment variable to docker-sqitch.sh.
Update the CI/CD workflow to use the latest Docker actions for assembling metadata, building, testing, and pushing multi-platform Docker images. Cease using the `./build` script in the workflow, but update it to build images for multiple platforms. To have both the CI/CD workflow and the `./build` script in sync, add the `.envrc` file and teach both to read from it for common values, especially the Sqitch version. Fix an issue building Sqitch on ARM64 by installing List::MoreUtils::XS before building Sqitch; otherwise it hangs and times out during the configure phase for that module. Update the Oracle `Dockerfile` to always install the latest Instant Client; no more need to edit it for new versions. Also teach it to properly install ARM64 client libraries, but disable building for ARM64 in the `Makefile`, for now, until a [bug building DBD::Oracle] can be fixed. Update the Snowflake `Dockerfile` to install the ARM64 ODBC driver on ARM64 Linux, but limit builds to AMD64 in the `Makefile`, for now, until [SnowSQL gets ARM64 support]. Limit the Exasol build to AMD64, as there are currently no Exasol libraries for ARM64. Remove reference to Vertica, for which there is not yet Docker support. [bug building DBD::Oracle]: https://rt.cpan.org/Ticket/Display.html?id=149876 [SnowSQL gets ARM64 support]: https://community.snowflake.com/s/question/0D5Do00000ltxpVKAQ/snowsql-linuxarm64-support
yifanwu-kolena
commented
Feb 8, 2024
| @@ -6,7 +6,7 @@ NAME=sqitch | |||
| VERSION=1.3.1 | |||
|
|
|||
| DIR=${DIR:=.} | |||
| PY_VERSION=${PY_VERSION:="3.9"} | |||
| PY_VERSION=${PY_VERSION:="3.9.17"} | |||
There was a problem hiding this comment.
| @@ -58,10 +60,11 @@ RUN mkdir -p /usr/share/man/man1 /usr/share/man/man7 \ | |||
| && chown -R sqitch:sqitch /home | |||
|
|
|||
| RUN apt-get update && apt-get install -y python3-pip curl git-lfs | |||
| RUN pip install poetry==1.2.2 | |||
| RUN pip install poetry==1.7.1 | |||
There was a problem hiding this comment.
yifanwu-kolena
changed the title
ly-kolena
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d153a58 is the only update, all other stuff is just sync from upstream
bump the base image to fix this issue