Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper bound for requests instead of forcing new requests-toolbelt #11

Merged
merged 3 commits into from
May 11, 2023

Conversation

gordonhart
Copy link
Member

Seeing issues installing latest on trunk as well as the latest 0.68.0 release on different environments. Looks like it boils down to the requests-toolbelt>=1 pin being too new (breaks compatibility with libraries that pin e.g. requests-toolbelt^0.9) and the requests==2.30 release causing issues in the ecosystem that haven't fully shaken out (see psf/requests#6443, psf/requests#6432).

This PR addresses the problem by unpinning requests-toolbelt, which should be driven mostly by the requests version, and adding an upper bound requests<2.30 with a TODO to rip out once things settle.

Copy link
Contributor

@ly-kolena ly-kolena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow cannot reproduce this using kolena-client-contrib/demo docker build as a testbed. Suppose better the old enemies we know.

@gordonhart
Copy link
Member Author

gordonhart commented May 10, 2023

One of the incompatibilities I'm seeing is with poetry installed in the same environment:

$ python3 -m pip install kolena-client
...
poetry 1.4.2 requires requests-toolbelt<0.11.0,>=0.9.1, but you have requests-toolbelt 1.0.0 which is incompatible.

I'm sure there are other common libraries that have major version pins on requests-toolbelt. I think it's best for us to give things time, rather than requiring a new major version a few days after it landed.

@gordonhart gordonhart force-pushed the gh/unbreak-requests branch from a593ac6 to a52580c Compare May 11, 2023 14:26
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #11 (704409a) into trunk (6d4582c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk      #11   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          93       93           
  Lines        5865     5865           
  Branches      640      640           
=======================================
  Hits         5016     5016           
  Misses        767      767           
  Partials       82       82           

@gordonhart gordonhart merged commit 2000f12 into trunk May 11, 2023
@gordonhart gordonhart deleted the gh/unbreak-requests branch May 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants